Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke grenade rework #3115

Draft
wants to merge 3 commits into
base: Development
Choose a base branch
from
Draft

Smoke grenade rework #3115

wants to merge 3 commits into from

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Apr 30, 2024 •
edited
Loading

Additions

  • New white smoke flecks, based off the vanilla tox smoke.
  • New effecter for smoke grenade, which spews white smoke and makes an appropriate sound.

Changes

  • Rather than exploding in cloud of smoke, the smoke grenade now lands on the ground and begins to spew a cloud of smoke, similar to the Biotech tox mortar shell.

Reasoning

  • While it has less immediate dispersion, the smoke cloud lasts considerably longer with this implementation and still covers a similar-sized area. This makes it a bit better for providing screening, and potentially more appealing for the player to use.

Alternatives

  • Could leave it as-is.
  • Could convert other smoke grenades over to this format, but most--such as launched grenades--have a much smaller payload.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners April 30, 2024 06:55
@N7Huntsman N7Huntsman marked this pull request as draft April 30, 2024 06:55
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8890568360.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Apr 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8917346492.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review May 26, 2024 22:09
@N7Huntsman N7Huntsman marked this pull request as draft June 27, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@N7Huntsman