Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rimsenal vanilla 1.5 underbarrels #3119

Merged

Conversation

Tostov
Copy link
Contributor

@Tostov Tostov commented May 6, 2024

Add the underbarrel weapons.

Additions

Added patches for the three cat-weapons added by the new 1.5 update

Changes

Tweaks to carbine and BR stats
Changed the carbine to SB 5.56 as it is a short barrel variant

Reasoning

Implemented the underbarrels with CE's underbarrel comp as it is not clear how we will be updating comp ability weapons going forward.

Alternatives

If an alternative comes up regarding the comp ability, we could use that implementation instead.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

Add the underbarrel weapons.
@Tostov Tostov requested review from a team as code owners May 6, 2024 15:45
Copy link

github-actions bot commented May 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8971891448.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 6, 2024
@N7Huntsman N7Huntsman merged commit d82ae0b into CombatExtended-Continued:Development May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants