Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Height Fuse shell offset problem #3128

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix the Height Fuse shell offset problem #3128

merged 1 commit into from
May 19, 2024

Conversation

yuganxia
Copy link
Contributor

Additions

Describe new functionality added by your code, e.g.
Add back the missing + in the code.

Changes

Fix the offset of projectiles have hight fuse.

References

Links to the associated issues or other related pull requests, e.g.

Reasoning

Bug fix

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

@yuganxia yuganxia requested review from a team as code owners May 10, 2024 12:36
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9032325387.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 10, 2024
@masakitenchi
Copy link
Contributor

same issue as #3062 , but it hasn't been merged into dev

Airomeda
Airomeda approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

playtested with all possible airburst projectile, works as intended 👍

@N7Huntsman N7Huntsman merged commit 6ea7f10 into CombatExtended-Continued:Development May 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@masakitenchi masakitenchi masakitenchi approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Indirect Airburst shell isue
4 participants
@yuganxia @masakitenchi @N7Huntsman @Airomeda