Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maru Race CE patch. #3139

Merged
merged 10 commits into from
May 26, 2024

Conversation

Tostov
Copy link
Contributor

@Tostov Tostov commented May 17, 2024

Additions

Patches for Maru stuff.

Bows cannot currently consume multiple projectiles when using the verb, but the intent is there at least. Firing properties for some bows change when deployed, so the intent is to keep that

Reasoning

At least three items are not patched since they seem to use a irregular system to generate their effects. Two of these three known items work anyway, it's only the defensive structure that doesn't.

There's a number of rebuild recipies that exist seperate from onces I've removed/changed but I can't figure out how to place the workbench down that has access to them.

Alternatives

Could just clear all the recipes and itemcosts, but this causes the game to crash during startup, so not sure what's wrong there.

Regarding the bows, an alternative ammo could be added for those that have a drastically different shot that is only avaliable to the alt fire mode they have.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@Tostov Tostov requested review from a team as code owners May 17, 2024 06:34
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9124020167.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 17, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9132021894.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9132030555.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesus. @Tostov put line breaks between the different defs so they're readable, especially in these long files.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9170184765.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9170593887.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9170630198.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9206095287.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9206440873.zip

@N7Huntsman N7Huntsman merged commit beabf64 into CombatExtended-Continued:Development May 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants