Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Application Rework #3140

Draft
wants to merge 6 commits into
base: Development
Choose a base branch
from
Draft

Conversation

AluminumAlman
Copy link
Contributor

@AluminumAlman AluminumAlman commented May 17, 2024

Changes

  • No more code separation between partial penetration and deflection blunt damage - instead sharp damage decays to blunt damage at a rate;
  • Use the initial damage worker for all damage applications against pawns;
  • Apply body part density to part damage calculations with custom handling of damage propagation of hit internal body parts;
  • Partial armor stat system now supports shield coverage from the shield extension.

Reasoning

  • The separation between partial penetration and deflection blunt damage was a band-aid fix to implement partial penetration; that is no longer the case. New class - AttackInfo - is now used for storing information damage info penetration information: current penetration amount, damage per penetration amount, one unit of penetration amount decaying to how much of the next attack info penetration amount and the next damage info;
  • Fixes partial penetrations using the blunt damage worker to apply additional damage to bones;
  • Body part density only affected penetration amount, which meant that it could only cause deflections, but not change damage. Vanilla damage propagation was limited - different parts couldn't have different damage amounts, therefore a custom solution was implemented.

Testing

  • Compiles without warnings;
  • Game runs without errors;
  • Playtested a colony.

Additional notes

  • Working body part density
    image

@AluminumAlman
Copy link
Contributor Author

AluminumAlman commented May 17, 2024

PR is a draft because of lack of code documentation, comments and debug logging.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9126125618.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 17, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9229115965.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9246600096.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant