Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Ammo Float Menu Typo Fix #3144

Conversation

ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented May 18, 2024

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Changes code to allow translations to use {0} in place of subject
  • Update existing English, Chinese Simplified, and Portuguese translations to utilize correctly

Reasoning

Why did you choose to implement things this way, e.g.

  • Allows translations that do not follow same sentence structure as English to have proper translation

Alternatives

Describe alternative implementations you have considered, e.g.

  • Add a space directly in the C# code
    • Not as flexible as using {0} for the subject
  • Leave typo of "Give Ammo to{SUBJECT]" on float menu

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

* Changes code to allow translations to use {0} in place of subject
* Update existing English, Chinese Simplified, and Portuguese translations to utilize correctly
@ViralReaction ViralReaction requested review from a team as code owners May 18, 2024 16:07
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9141078059.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 18, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing.

@N7Huntsman N7Huntsman merged commit fcbb1c9 into CombatExtended-Continued:Development May 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants