Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vanilla stunnable comp for auto turrets #3146

Merged
merged 6 commits into from
May 22, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented May 21, 2024

Additions

  • Add the vanilla Comp_Stunnable to CE's auto turrets.

Changes

  • Make it so 'Stun' damage doesn't stun vanilla auto turrets.
  • Remove Comp_Stunnable from the mortar.

Reasoning

  • The new comp was implemented in 1.5 and allows us to hand-off the EMP-stun behavior to the vanilla comp instead of managing it in our code. Since the comp largely duplicates our functionality, it's preferable to switch over to the vanilla comp, since it's already exposed to xml and we don't have to work about maintaining it ourselves.
  • For CE's purposes, we probably don't want flashbangs to be able to do the job of EMP rounds by stunning auto turrets.
  • Why could a mortar be stunned...?

References

Should be merged after #3135

Alternatives

  • Could continue to use our coded stun for auto turrets, I suppose.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners May 21, 2024 02:55
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9168111629.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 21, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9170705740.zip

Thorbane
Thorbane previously approved these changes May 21, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9186408870.zip

@N7Huntsman N7Huntsman merged commit 82e414c into Development May 22, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Stunnable-Comp branch May 22, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants