Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn compat assembly building back on #3164

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Turn compat assembly building back on #3164

merged 1 commit into from
Jun 6, 2024

Conversation

Rhinous
Copy link
Contributor

@Rhinous Rhinous commented May 31, 2024

Changes

  • Turn compat assembly building back on by uncommenting it in the workflows

Reasoning

  • Makes testing fixes to the compat patches way easier and allows people to test the patches for bugs on 1.5 as you don't have to build locally
  • None of the compat patches give errors on startup when building locally unless they are outdated and their specific mod is enabled, so theres no real reason to keep them disabled

@Rhinous Rhinous requested review from a team as code owners May 31, 2024 03:56
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9312684476.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 31, 2024
N7Huntsman
N7Huntsman approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're reasonably confident nothing is going to explode, so no reason not to.

@N7Huntsman N7Huntsman merged commit 485050d into CombatExtended-Continued:Development Jun 6, 2024
2 checks passed
@Rhinous Rhinous deleted the building branch June 7, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rhinous @N7Huntsman