Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. Patch Updates #3165

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Misc. Patch Updates #3165

merged 9 commits into from
Jun 4, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Jun 1, 2024 •
edited
Loading

Changes

  • Load VFE - Tribals and Classical after CE, so their thrown weapons have the correct base.
  • No longer force VFE - Mechanoids to load before CE.
  • ReGrowth: Core - remove moa patch, add kiwi patch.
  • Rimsenal Spacer Faction - Remove duplicate explosive recipe parent base.
  • Rimsenal Core:
    • Fix JI siege rocket parent name.
    • Update apparel verbs
    • Fix duplicate Fed plasma projectile defName
    • Remove duplicate FeralNail ammo category.
    • Load Factions before CE and make some weaponTag operations conditional to prevent errors about duplicates.
  • VFE: Security - Menu hide the raider artillery and remove the dummy research project
  • VWE: Grenades & VAE: Accessories - Update apparel verbs.
  • Small whitespace changes in a bunch of files to improve readability.

Reasoning

  • Necessary fixes.

Alternatives

  • Leave stuff broken, I guess.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners June 1, 2024 02:27
@N7Huntsman N7Huntsman marked this pull request as draft June 1, 2024 02:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9326880672.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9328956254.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9329022456.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9336478463.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9342410877.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9359858451.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9359922534.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review June 4, 2024 01:52
Airomeda
Airomeda approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended 👍

@N7Huntsman N7Huntsman merged commit 4a80461 into Development Jun 4, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the 1.5-Patch-Updates branch June 4, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @Airomeda