Fixes for siege mortar ammo

[Rhinous]

Additions

• Added an extra field to the AmmoDef class spawnAsSiegeAmmo which when set to false for a shell will blacklist it from spawning as siege ammo

Changes

• Removed the harmsHealth check for mortar siege ammo to allow for shells whose damagedefs don't directly harm health to be used by sieges such as Tox Gas shells, Airburst or those added by the Biological Warfare mod
• Added spawnAsSiegeAmmo false to the patch for Firefoam and Smoke shells, stopping them from spawning in sieges
• Reworked the transpiler patch for LordToil_Siege.LordToilTick so that checking what ammo is available on the ground is the same as what gets called in

Reasoning

• The old implementation was broken and was spawning every type of shell including firefoam and smoke (non-lethal)
• The addition of spawnAsSiegeAmmo to AmmoDef allows for easy patching of modded shells and allows for fine control of which shells are used in a siege
• Before there was no patch for if the ammo currently on the ground was counted in the same way that the resupply patch saw it. This meant that you could in rare cases end up with a possible infinite loop of calling in more resupply's every few seconds.
• Had to use a transpiler as the logic is done internally. Transpiler patch replaces the following if condition
  

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• Playtested a colony (specify how long) - Devtest spawning siege raids having them shoot until they get resupplied and removing their ammo repeatedly to force a resupply

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9361492548.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9397495729.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9397817283.zip

[Airomeda]

works as intended, the endless shell reinforcement pod bug is also gone 👍

[N7Huntsman]

I honestly think this is probably something we'd prefer to add to the ammo item, rather than the DamageDef itself--that leaves us finer control over what does or doesn't spawn for mortar shells dropped to sieges. Thoughts?

[Rhinous]

Yeah I don't really like how currently we can't control it per shell, was originally done this way to stay similar to the old/vanilla method of just checking damage but it's definitely gotten bloated/overcomplicated. What do you think about scrapping the damage/harmshealth checks entirely and instead adding something like SpawnAsSiegeAmmo to the AmmoDef class? That way we can just blacklist shells we don't want since I think default behaviour should be to include them

[N7Huntsman]

Yeah, I think an easy true/false we can just assign to each shell as an override is probably our easiest way to address edge cases. Leave the more straight-forward checks in the code to filter out shells that obviously aren't suitable for siege, but we'll just use xml to address any outliers as necessary. Otherwise, we end up with a hideous, expensive string of checks that still will find a way to let some strange shells spawn when they shouldn't.

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9425307782.zip

[Rhinous]

Updated to use spawnAsSiegeAmmo instead. Still filters out shells who have no projectile or explosive damagedef or dont pass the checks for marketvalue / emp. Check the updated xml patch for the firefoam and smoke shells for example usage.