Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some PatchOpAdd Defs #3181

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Clean up some PatchOpAdd Defs #3181

merged 3 commits into from
Jun 25, 2024

Conversation

N7Huntsman
Copy link
Contributor

Changes

  • Convert a handful of lingering patched-in Defs from patch files to proper Defs.

References

Reasoning

  • With LoadFolders available to us for Defs, there's really no reason to patch in these Defs anymore.

Alternatives

  • Could leave them alone.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners June 9, 2024 00:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9432778700.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 9, 2024
@N7Huntsman N7Huntsman marked this pull request as draft June 9, 2024 01:21
@N7Huntsman N7Huntsman marked this pull request as ready for review June 25, 2024 09:09
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9659758663.zip

Airomeda
Airomeda approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@N7Huntsman N7Huntsman merged commit 75c2bdb into Development Jun 25, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the LoadFolder-CleanUp branch June 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @Airomeda