Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWC update #3187

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

BRLWK
Copy link
Contributor

@BRLWK BRLWK commented Jun 12, 2024

Additions

Describe new functionality added by your code, e.g.

  • 6.5x21mm APS ammunition that requires Armor-piercing special mod.

Changes

Describe adjustments to existing features made in this merge, e.g.
-Used new CE spreadsheets to rebalance patch.
-Changed some odd decisions like 4-rn burst on battle rifle. Removed bipods that were missing from sprites.

  • Decreased power and resource cost of 7.7mmPC cartridge.
  • Weapons reflect new cartridge changes.

References

Links to the associated issues or other related pull requests, e.g.

  • Closes #[ISSUE_NUMBER]
  • Contributes towards #[ISSUE_NUMBER]

Reasoning

Why did you choose to implement things this way, e.g.

  • 7.7mmPC was a copy of 7.7 Arisaka, now closer to an intermediate.
  • 6.5x21mm APS ammunition is better balanced than sabot, kept sabot def as to not break games.
  • Updating integrated modularweapons patch with new recoil values, needs to be reflected in CE patch.

Alternatives

Describe alternative implementations you have considered, e.g.

  • Considered renaming def and name for both munitions to new smaller, lighter dimensions; would break games.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (1 colony, two months, 9 years in-game.)

@BRLWK BRLWK requested review from a team as code owners June 12, 2024 04:20
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9476657782.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 12, 2024
@BRLWK BRLWK closed this Jun 14, 2024
@N7Huntsman N7Huntsman reopened this Jun 14, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9510518540.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9510557098.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got in touch with the author and the patches are going to be moved over to the mods' side. This is preferable both because the author has a fairly particular idea in mind for the mod's balance with CE, and because this patch does some things we generally avoid doing in compatibility patches--chiefly, adding new guns and re-labeling existing ones.

@N7Huntsman N7Huntsman merged commit 539bcfd into CombatExtended-Continued:Development Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants