Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect penetration value #3191

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Fixed incorrect penetration value #3191

merged 1 commit into from
Jun 16, 2024

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented Jun 16, 2024

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Fixed incorrect calculations due to syntax sugar

References

Links to the associated issues or other related pull requests, e.g.

Reasoning

Why did you choose to implement things this way, e.g.

  • No damage

Original code was compiled to this:
image

Alternatives

Describe alternative implementations you have considered, e.g.

  • Destroy centipede with molotov

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (tested and compared pentration of disposable launcher)

@MaxDorob MaxDorob marked this pull request as ready for review June 16, 2024 14:36
@MaxDorob MaxDorob requested review from a team as code owners June 16, 2024 14:36
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9536768169.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 16, 2024
Copy link
Contributor

@SamaelGray SamaelGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended.

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue.

@N7Huntsman N7Huntsman merged commit 7390468 into Development Jun 16, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the PenetrationFix branch June 16, 2024 18:25
masakitenchi added a commit to masakitenchi/Hardcore-SK that referenced this pull request Jun 16, 2024
- Fix: player can repair hostile mech's armor; CombatExtended-Continued/CombatExtended#3191
- Fix: bullet penetration lower than it is expected to be CombatExtended-Continued/CombatExtended#3189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Armor Penetration system seems does not seem to be working properly
4 participants