Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Neck BodyPart for melee targeting #3206

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Use Neck BodyPart for melee targeting #3206

merged 3 commits into from
Jun 24, 2024

Conversation

perkinslr
Copy link
Contributor

Changes

1.5 removed the Neck def from the BodyPartDefOf provided by core RW. This adds it to our own CE_BodyPartDefOf and uses it for the targeting pieces that used to target neck (and currently target eyes).

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners June 23, 2024 06:28
@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 23, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9631457561.zip

N7Huntsman
N7Huntsman previously approved these changes Jun 23, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing.

@perkinslr perkinslr dismissed N7Huntsman’s stale review June 23, 2024 22:23

The merge-base changed after approval.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9636873770.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9636900441.zip

Thorbane
Thorbane previously approved these changes Jun 23, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9637275507.zip

@N7Huntsman N7Huntsman merged commit ff9c874 into Development Jun 24, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the eyetoneck branch June 24, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants