Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moyo 2 patch #3215

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Conversation

Tostov
Copy link
Contributor

@Tostov Tostov commented Jun 26, 2024

Additions

Patches for the new version of moyo content. Old stuff remains since they're a different mod technically and there's a cont'd version on the workshop that if it has the same package ID as the original, should load our patches anyway

Changes

Minor changes to the abyssteel. A number of weapons are outright different or don't have old equivalents.

Reasoning

Currently, we use the now shared ammo underbarrel comp to do the overclocked firing modes. In vanilla this actually outright changes what the weapon is, but that functionality breaks the ammo comp that we have, not transfering said data across.

Alternatives

We could make the guns fire from inventory, which sidesteps the ammo deleting/unloading problem when switching the item from one to the other. Alternatavely, a compatability module could be set up for the specifc comp.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@Tostov Tostov requested review from a team as code owners June 26, 2024 10:32
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9678065232.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 26, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses Bioferrite in a couple of recipes, which can potentially cause errors if the player doesn't have Anomaly/doesn't have it loaded.

ModPatches/Moyo 2/Defs/Moyo 2/Ammo/Ammo_Moyo_Laminar.xml Outdated Show resolved Hide resolved
ModPatches/Moyo 2/Defs/Moyo 2/Ammo/Ammo_Moyo_Laminar.xml Outdated Show resolved Hide resolved
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9688548743.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9688712401.zip

Updated recipes to be correct.
Fixed labelShort
Added benches/tech for recipes.
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9692312173.zip

@Tostov
Copy link
Contributor Author

Tostov commented Jun 27, 2024

Uses Bioferrite in a couple of recipes, which can potentially cause errors if the player doesn't have Anomaly/doesn't have it loaded.

Should all be to correct materials now, techs added and recipe users where applicable. Also fixed the short label (copy of another ammo file as a basis) but feel free to change it to a different one if you have a suggestion.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9692939233.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9692957896.zip

@N7Huntsman N7Huntsman merged commit 66167d4 into CombatExtended-Continued:Development Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants