Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc ammo housekeeping #3227

Merged
merged 15 commits into from
Sep 6, 2024
Merged

Misc ammo housekeeping #3227

merged 15 commits into from
Sep 6, 2024

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Jul 1, 2024 •
edited
Loading

Changes

https://docs.google.com/spreadsheets/d/1P9U8EtYoRBh-jPMPmXcqam1O3qvKZPMml2ktAMPssOk/edit?gid=1393347070#gid=1393347070

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@SamaelGray SamaelGray requested review from a team as code owners July 1, 2024 09:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9742027828.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9751324960.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9763817243.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9807313826.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9847099594.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10452317868.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10545475699.zip

@SamaelGray
secondary damage changes reverted
53b0309 
being split into another PR/branch
@SamaelGray SamaelGray changed the title Secondary damage decoupling and housekeeping Misc ammo housekeeping Aug 30, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10627995668.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10685177733.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10685498603.zip

N7Huntsman
N7Huntsman previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine. Need a clarification on the stickbomb filler amount (discord).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10733254195.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10733268124.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10733388194.zip

@N7Huntsman N7Huntsman merged commit 060e507 into CombatExtended-Continued:Development Sep 6, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-SecondaryDamageDecoupling branch September 6, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamaelGray @N7Huntsman