Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grimworld 40000 Patch Integration #3235

Merged
merged 47 commits into from
Sep 4, 2024
Merged

Grimworld 40000 Patch Integration #3235

merged 47 commits into from
Sep 4, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Jul 3, 2024 •
edited
Loading

Additions

  • Integrate existing Grimworld 40000 patches and assets at mod author's request.
  • Patches for: Core Imperialis, Angels of Death, Hammer of the Imperium, Vehicles of the Imperium
  • Various art assets.

Changes

  • Move some of the 40k textures around.

References

  • TBD

Reasoning

  • TBD

Alternatives

  • Different balancing scheme.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners July 3, 2024 01:36
@N7Huntsman N7Huntsman marked this pull request as draft July 3, 2024 01:36
@N7Huntsman N7Huntsman self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9770459464.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jul 3, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9887305288.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9887326531.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9887742897.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9887859335.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10086219579.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10086932824.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10086955441.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10087192474.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10154942713.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10155071323.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10443941468.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10444955753.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10482558482.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10588963294.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10589095275.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10607352483.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10607617164.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10607728540.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10623763985.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10623834590.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10624510747.zip

@ViralReaction
Copy link
Contributor

Rest of the changes look pretty good.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10649533554.zip

ViralReaction
ViralReaction approved these changes Sep 4, 2024
View reviewed changes
...tches/Grimworld Core Imperialis/Defs/Grimworld Core Imperialis/Ammo/CE_Patch_VolkiteAmmo.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volkite meant to be more Anti-Personnel, with exploding people it kills to damage others around it. Is it possible to add fragments to a laser?

@N7Huntsman N7Huntsman merged commit 05508c6 into Development Sep 4, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the GrimWorld-Patch-Integration branch September 4, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralReaction ViralReaction ViralReaction approved these changes

Assignees

@N7Huntsman N7Huntsman

Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @ViralReaction