More casing variables #3258
Merged
More casing variables #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9861868689.zip |
github-actions
bot
added
the
Download in Comments
|
Please do the indentation style fix on this PR too. |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10035045118.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10035108956.zip |
N7Huntsman
approved these changes
Jul 22, 2024
Thorbane
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a celling for casing lifetime, so that slow casings don't keep falling for too long.
A metric load of variables that will be enabled if AdvancedCasingVariables is true in gundrawext, including random ranges for casing eject angle, casing rotation, random spawn offset range. And multipliers and overrides for casing lifetime and speed.
Reasoning
-Deal with very-very edge case
-Prevent guns with too low recoil from behaving weird.
-Extra fine tuning freedom
-Most logic locked behind AdvancedCasingVariables so they don't burden most weapons too much.
Alternatives
-Suffer
Testing
Check tests you have performed: