Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VFE Insectoids - 2 patch #3275

Merged
merged 10 commits into from
Sep 7, 2024
Merged

VFE Insectoids - 2 patch #3275

merged 10 commits into from
Sep 7, 2024

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Jul 15, 2024 •
edited
Loading

Additions

  • What it says on the tin. Currently patched:

    • New PawnKind

    • New chitin material

    • New races

    • New DamageDefs

      • Haven't patched the abilities yet, haven't tested yet so they might or might not need patching.
      • Two insect turrets are added to the mod, one normal MG style and another being a mortar, dunno if they require patching or not.
      • There is a new trap-like building that shoots spikes when a pawn is close to them, like that helldivers 2 spikey plant thing, currently not patched and seems complex enough to not be fully patchable for CE.

Reasoning

  • For democracy!
  • The armor degradation mechanic of the Xanides geneline doesn't work as good as CE's natural armor durability, the hediff does not progress between each stage in my testing and it's not gradual enough so it's best replaced.

Alternatives

  • No E-710.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@SamaelGray SamaelGray requested review from a team as code owners July 15, 2024 22:01
@SamaelGray SamaelGray marked this pull request as draft July 15, 2024 22:01
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9947264034.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jul 15, 2024
@SamaelGray SamaelGray marked this pull request as ready for review July 15, 2024 22:04
@SamaelGray SamaelGray marked this pull request as draft July 15, 2024 22:04
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9953682317.zip

@SamaelGray SamaelGray marked this pull request as ready for review July 16, 2024 08:50
@SamaelGray SamaelGray changed the title VFE Insectoids - 2 patch (WIP) VFE Insectoids - 2 patch Jul 16, 2024
@SamaelGray SamaelGray marked this pull request as draft July 17, 2024 16:43
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10018412288.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10353957016.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10359671338.zip

@SamaelGray
swarmling body patch fix
a51eb18 
accommodate for the upstream change
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10426812167.zip

@LtChae
Copy link

LtChae commented Aug 17, 2024

Excited for this, keep up the good work!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10685773582.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10746035263.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10746432335.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review September 6, 2024 23:50
N7Huntsman
N7Huntsman previously approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here looks fine. A few concerns for other stuff within the mod but that we can't currently support:

  • Projectiles for the thorn turret and spike mine don't support CE armor mechanics. So while they're fine against unarmored targets, they only deal bruises against even the thinnest of apparels.
  • The mod scenario starting colonists don't have sufficient bulk capacity for ammo, and for whatever reason, I can't get them to spawn with CE backpacks or tac vests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10747780330.zip

@N7Huntsman N7Huntsman merged commit fd8c80c into CombatExtended-Continued:Development Sep 7, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-VFEI2 branch September 7, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamaelGray @LtChae @N7Huntsman