Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aitburst shell frag amount fix #3281

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Aitburst shell frag amount fix #3281

merged 1 commit into from
Aug 6, 2024

Conversation

SamaelGray
Copy link
Contributor

Changes

  • Changed the Airburst shells to throw 1.5 times the amount of frags of normal HE shells.
  • Fixed the indentation style of the files in the meantime.

References

Reasoning

  • Shells that lack an explosive component and are meant to kill with frags should not have the same, or even less in the case of 81mm shells, the frag numbers than HE shells, it's counterintuitive and makes them useless.

Alternatives

  • Keep things as is and have yet another useless ammo type, suffer as a result.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

@SamaelGray SamaelGray requested review from a team as code owners July 18, 2024 08:32
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9988217235.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jul 18, 2024
@N7Huntsman N7Huntsman merged commit 7543361 into CombatExtended-Continued:Development Aug 6, 2024
2 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-AirburstShellFragFix branch August 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamaelGray @N7Huntsman