-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOS2 Patch - GroundDefenseMode compatibility #3282
SOS2 Patch - GroundDefenseMode compatibility #3282
Conversation
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9990525588.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turrets work in my testing.
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10362807588.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10362818735.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shields, torpedoes, and turrets on landed ships all work in my testing.
playtested it a bit and there seems to be a noticeable performance impact, otherwise works fine 👍 |
a536e77
into
CombatExtended-Continued:Development
Additions
Changes
holdFire
,WarmingUp
andCanToggleHoldFire
from private to protected inBuilding_GunTurretCE
References
Reasoning
Alternatives
Testing
Check tests you have performed: