Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(load-folder): Add continued version of DD House Sanguin & Elves #3299

Conversation

kaeh
Copy link
Contributor

@kaeh kaeh commented Jul 22, 2024

Additions

  • Add continued version of both DD Elves & DD House Sanguin in LoadFolders to apply correct patches

Changes

Nothing.

References

Reasoning

Why did you choose to implement things this way, e.g.

  • Adding instead of replacing to keep v1.4 running nad be able to remove it easily when/if both mod are updated by the original mod author

Alternatives

Could have copy/paste complete DD patch folders but that would have been combersome

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

chore(load-folder): Add continued version of DD House Sanguin & Elves
@kaeh kaeh requested review from a team as code owners July 22, 2024 17:10
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10045284598.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jul 22, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10050390293.zip

kaeh added 2 commits July 23, 2024 22:21
I had deleted the first part of the mod ids without seeing it before commit, sorry.
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10065833313.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10065854677.zip

@N7Huntsman N7Huntsman merged commit 4a1aae1 into CombatExtended-Continued:Development Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants