Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rah's Vanilla Turrets Expanded Patch Update #3322

Conversation

Merwini
Copy link
Contributor

@Merwini Merwini commented Aug 1, 2024

Additions

Changes

  • Removed patches for VulcanCannon, VulcanCannonManned, ChargeCannon that change their passability and pathCost

References

Reasoning

  • These turrets are no longer impassable in the base mod, making the patches unnecessary, and also causing errors due to targeting nonexistant node on those defs.

Alternatives

Testing

Check tests you have performed:

  • [ X ] Compiles without warnings
  • [ X ] Game runs without errors
  • [ X ] (For compatibility patches) ...with and without patched mod loaded
  • [ X ] Playtested a colony (specify how long) - spawned the turrets in question, forced a pawn to walk through them, forced pawns to reload them, forced them to fire on a target

@Merwini Merwini requested review from a team as code owners August 1, 2024 13:45
Copy link

github-actions bot commented Aug 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10199556627.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 1, 2024
@N7Huntsman N7Huntsman merged commit fb3270e into CombatExtended-Continued:Development Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants