-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated loader #3330
Updated loader #3330
Conversation
they must be located under ModPatches
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226553529.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226596762.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226696142.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226740743.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226760340.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226798249.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10232775569.zip |
instead of package id of the offending files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything that's obviously horribly wrong, I don't know if I understand what it's interfacing with well enough to promise it'll work, but it shouldn't wreck anything aside from itself.
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10346966034.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built locally and tested with VFE, no issues.
Additions
DupeFinder.py will find duplicate entries under LoadFolders inclusions and report them.
Changes
The dedicated loader functionality is half merged into the base dll and half migrated to the LoadFolders system.
The compat builder reads the destination from the .csproj file.
Reasoning
The LoadFolders system already does most of what we want - only loading dlls when they are needed
So we just need to manage multiple settings sources and any post-init work.
The updated build scripts will completely remove the embedded binary when making a release build - better security
Testing
Check tests you have performed: