Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated loader #3330

Merged
merged 20 commits into from
Aug 17, 2024
Merged

Updated loader #3330

merged 20 commits into from
Aug 17, 2024

Conversation

perkinslr
Copy link
Contributor

Additions

DupeFinder.py will find duplicate entries under LoadFolders inclusions and report them.

Changes

The dedicated loader functionality is half merged into the base dll and half migrated to the LoadFolders system.
The compat builder reads the destination from the .csproj file.

Reasoning

The LoadFolders system already does most of what we want - only loading dlls when they are needed
So we just need to manage multiple settings sources and any post-init work.

The updated build scripts will completely remove the embedded binary when making a release build - better security

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners August 3, 2024 08:13
Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226553529.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 3, 2024
Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226596762.zip

Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226696142.zip

Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226740743.zip

Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226760340.zip

Copy link

github-actions bot commented Aug 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10226798249.zip

Copy link

github-actions bot commented Aug 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10232775569.zip

Copy link

@tlhonmey tlhonmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything that's obviously horribly wrong, I don't know if I understand what it's interfacing with well enough to promise it'll work, but it shouldn't wreck anything aside from itself.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10346966034.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally and tested with VFE, no issues.

@perkinslr perkinslr merged commit 3915b41 into Development Aug 17, 2024
2 checks passed
@perkinslr perkinslr deleted the updated-loader branch August 17, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants