Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MO Barbarians patch #3344

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Aug 9, 2024

Changes

  • What it says on the tin, the patchable content from the mod is patched including apparel, pawnKinds, weapons and the horse.

Reasoning

  • Values are relative to the existing vanilla and base CE gear adjusted accordingly.
  • The banners and shields are patched similarly to pphhyy Demipryphs patch update #3328 as they are pretty much the same thing that look different.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors (Have not loaded with the refactored shield patches yet)
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (Testing left for after Update MO patch #3343 has gotten readier for merging)

@SamaelGray SamaelGray requested review from a team as code owners August 9, 2024 11:39
Copy link

github-actions bot commented Aug 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10318596368.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 9, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10338956810.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10379644113.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10379805913.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a start-up error associated with the northern horse hitbox due to a typo in one of the lifestage graphic paths. I've submitted a PR with a fix to the MO Barbarians repo, but there's nothing we can really do from our side.

@N7Huntsman N7Huntsman merged commit d160203 into CombatExtended-Continued:Development Aug 15, 2024
2 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-BarbariansPatch branch August 15, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants