Update Workflows for new Loader #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10430549012.zip |
perkinslr
force-pushed
the
Update-Workflows-for-new-Loader
branch
from
1b5fe60 to
a78f6b7
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10430574163.zip |
MadaraUchiha
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
A python script that runs on PRs to check for duplicate xml paths in the virtual filesystem.
Changes
CombatExtendedLoader.dll gets stripped from built versions.
CompatAssemblies and related resources are removed.
Reasoning
The loader functionality is now embedded in
CombatExtended.dll. The Loader dll still exists to warn people they are running the uncompiled source tree, but it is not needed in a built version, so is removed prior to zipping the mod.Testing
Check tests you have performed: