Add Shield Information to UI #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Shows what the shield protects in the information tab * Shows what the shield protects in the Gear ITab when hovered over * Armor values in GearTab properly calculate shield armor
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10434356554.zip |
github-actions
bot
added
the
Download in Comments
ViralReaction
changed the title
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10481763757.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10482389997.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10732804058.zip |
* Adds null checks for the ITab Inventory when it comes to shield mod extension
|
Added null checks to prevent Gear Tab from breaking for a shield that is missing the normal modExtensions. |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10763253854.zip |
N7Huntsman
approved these changes
Sep 9, 2024
perkinslr
approved these changes
Sep 9, 2024
MaxDorob
approved these changes
Sep 10, 2024
N7Huntsman
merged commit b7547c1
into
CombatExtended-Continued:Development
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Describe new functionality added by your code, e.g.
Changes
Describe adjustments to existing features made in this merge, e.g.
Reasoning
Why did you choose to implement things this way, e.g.
Alternatives
Describe alternative implementations you have considered, e.g.
Testing
Check tests you have performed: