Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRE Lycans patch #3357

Merged
merged 2 commits into from
Aug 20, 2024
Merged

VRE Lycans patch #3357

merged 2 commits into from
Aug 20, 2024

Conversation

SamaelGray
Copy link
Contributor

Changes

  • Patched the superior dark vision gene from the mod with the CE night vision stat, same as the biotech dark vision gene that received it but this one is a better version of then hence the 0.9 efficiency.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (works)

@SamaelGray SamaelGray requested review from a team as code owners August 19, 2024 11:28
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10452479396.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 19, 2024
ViralReaction
ViralReaction previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ViralReaction ViralReaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working correctly. Vanilla DarkVision was patched to 0.80, so setting this at 0.90 seems inline for being slightly better.

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10465966258.zip

@N7Huntsman N7Huntsman merged commit ad366a7 into CombatExtended-Continued:Development Aug 20, 2024
2 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-LycansPatch branch August 20, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@ViralReaction ViralReaction ViralReaction left review comments

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamaelGray @N7Huntsman @ViralReaction