Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proj from tall shooter under roof ignore roof #3365

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

CMDR-Bill-Doors
Copy link
Contributor

@CMDR-Bill-Doors CMDR-Bill-Doors commented Aug 22, 2024

Changes

If a projectile was launched above roof height and under roof, this projectile will ignore roof.
Fly overhead projectiles that meets above criteria will ignore roof when ascending, and re-enable roof colision when descending.

Reasoning

So that tall shooter under roof won't end up hitting roof.

Alternatives

-Disallow tall shooters from going under roof
--Good luck with AI pathing.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (A few bursts from DMS super tall mechs under all sorts of roof)

@CMDR-Bill-Doors CMDR-Bill-Doors requested review from a team as code owners August 22, 2024 17:58
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10513193652.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 22, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10513296254.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10534742762.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing using DMS mech.

@N7Huntsman N7Huntsman merged commit b920d2c into Development Sep 21, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the TallShooterUnderRoofFix branch September 21, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants