Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Grenade Recipes & Quadruped Tail Fixes #3371

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Aug 25, 2024

Additions

  • Add recipes for Tox and Airburst to the generic grenade launcher ammo. Uses 40x46mm crafting stats.
  • Add Tox grenade to the generic launcher ammo set.

Changes

  • Add armor coverage to the tail of QuadrupedAnimalsWithPawsAndTail.

Reasoning

  • These grenades need to be craftable in generic ammo mode, too.
  • Entries within ammoTypes in an AmmoSetDef don't currently work with MayRequire, so we have to patch it.
  • Don't see a reason why the tail shouldn't be armored--probably just an oversight when the patch was made.

Alternatives

  • Suffer.
  • Fido keeps losing his tail.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners August 25, 2024 08:20
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10545414097.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 25, 2024
SamaelGray added a commit to SamaelGray/CombatExtended that referenced this pull request Aug 25, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10549707505.zip

@N7Huntsman N7Huntsman merged commit d3129ed into Development Aug 26, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the ArmoredTail branch August 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants