Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 gauge charged adjustments #3372

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Aug 25, 2024

Changes

  • Increased the sharp AP of the 12ga charged ammo types to 10, 15and 12.5
  • The slug ammo type had the incorrect amount of bomb damage (should have been 14), fixed that and increases the slug diameter by 1mm as there was just enough room for it.
  • Reduced the total length of the cartridge as it was the same as a normal 12ga disregarding the fact that charged ammo is caseless and so on.

Reasoning

  • Going with the normal charged ammo standard of the AP ratios and also the fact that 12ga charged buckshot pellets have the same exact velocity and mass, only 1 mm thinner in diameter which should even make them better at penetrating armor. So it makes 12mm for the base projectile, 18mm for the slugs same as how conc. is relative to normal charged and 15 for Ion same as normal Ion ammo but reduced the base AP value from 12 to 10 and adjusted the rest accordingly for reasons outside this PR.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@SamaelGray SamaelGray requested review from a team as code owners August 25, 2024 08:23
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10545439292.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 25, 2024
@SamaelGray SamaelGray changed the title 12 gauge charged sharp AP buff 12 gauge charged adjustments Aug 30, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10629317606.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10629460612.zip

@N7Huntsman N7Huntsman merged commit ce81178 into CombatExtended-Continued:Development Sep 3, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-12gaChargedBuff branch September 4, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants