-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThingSetMaker_CountEnabledAmmoOnly #3373
Conversation
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10549678860.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10694796339.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10767710036.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10767760937.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10768337108.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my testing.
Additions
A subclass of thingsetmaker_count and ThingSetMaker_StackCount which will validate if spawn thing is ammo and is enabled.
Variables:
basic, default true, can spawn non-advanced ammo.
advanced, default false, can spawn advanced ammo.
A subclass of thingsetmaker_count that, if spawned thing includes weapon with magazine, will add the weapon's ammo into spawned things.
Variables:
magCount, default intrange 2~5, the amount of ammo that will spawn with it.
random, default false, whether to spawn a random kind of ammo within ammoset, or the first kind of ammo in ammoset.
canGenerateAdvanced, default false, if random, if advanced ammo are included.
Same, but for Thingsetmaker_MarketValue
A patch that makes vanilla quest reward give ammo too if reward included a gun
Example:
Reasoning
We might find this useful if we want to add ammo into something's loot list.
Alternatives
Spawn player with ammo that they don't need.
Testing
Check tests you have performed: