Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic ammo fixes #3376

Merged

Conversation

Person243546
Copy link
Contributor

Additions

Adds 0.5 to generic shotgun ammo (emp) just like the non-generic versions

Changes

Renamed the label of revolver shotgun ammoset to "pistol". This fixes an issue where all pistol caliber bullets are called "revolver shotgun bullet"

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (few years in-game)

fix all pistol bullets being named "revolver shotgun bullet"
Add generateAllowChance to generic emp shotgun shells
@Person243546 Person243546 requested review from a team as code owners August 27, 2024 15:27
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10581187693.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 27, 2024
Copy link

github-actions bot commented Sep 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10693352228.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We'll deal with the label thing via #3378.

@N7Huntsman N7Huntsman merged commit fc1b92a into CombatExtended-Continued:Development Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants