Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MO Barbs Patch #3379

Merged

Conversation

ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented Aug 30, 2024

Additions

  • Add costList of 50 Steel to every shield. To fix issues with no costList in recipeMaker that is inherited and allows for smelting. Shields are created through a recipeDef
  • Add missing armor to all shields. Scales up from basic vanilla round steel round shield

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Move MO Barbs to proper Patches folder. LoadFolders require things to be put into Defs and Patches folder for it to properly load the xml.
  • Projectiles broken out into Defs to remove PatchOperationAdd
  • Fix broken shield patches
  • Remove old shield patches from BarbarianTallShields that were overriding changes.
  • Change Javelin patching to not remove the def and just replace what is needed changing.

Alternatives

Describe alternative implementations you have considered, e.g.

  • None

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (A few minutes to check patches)

@ViralReaction ViralReaction requested review from a team as code owners August 30, 2024 18:00
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10637116250.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 30, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10637280851.zip

Copy link

github-actions bot commented Sep 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10692936167.zip

@N7Huntsman N7Huntsman merged commit a8418a0 into CombatExtended-Continued:Development Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants