Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Industrial Stuff Patch #3381

Conversation

ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented Aug 30, 2024

Additions

Describe new functionality added by your code, e.g.

  • Removes tradeTags to prevent Ammo Injector errors with Remove Industrial Stuff

Reasoning

Why did you choose to implement things this way, e.g.

  • Mod leaves Cannonballs and Arrows that Ammo Injector attempts to add to respective Industrial workbenches that have since been removed.

Alternatives

Describe alternative implementations you have considered, e.g.

  • Rewrite the Ammo Injector

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (Used these patches for many playthroughs)

@ViralReaction ViralReaction requested review from a team as code owners August 30, 2024 18:56
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10637784880.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 30, 2024
@ViralReaction ViralReaction changed the title Remove Industrial Stuff Ammo Injector Fix Remove Industrial Stuff Patch Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10673367712.zip

@N7Huntsman N7Huntsman merged commit 855bc87 into CombatExtended-Continued:Development Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants