Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tox Grenade Min range #3383

Merged

Conversation

Tostov
Copy link
Contributor

@Tostov Tostov commented Sep 1, 2024

Changes

Removed the minimum range for tox grenades.

Reasoning

They're the same as flashbangs/smoke grenades where technically the explosion is unpleasant, but in most use cases you're wanting to actually throw these pretty close or cover yourself to slow down a non-tox immune target.

Alternatives

Complicated, but overall mechanism for changing minimum range based on threat to user. Not something I'd be able to implement though

Testing

Check tests you have performed:

  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

It's the same as a smoke or flashbang, close range less than lethal suppressive so it shouldn't have minimum range, even if most pawns throwing them certainly don't want to be caught up in it.
@Tostov Tostov requested review from a team as code owners September 1, 2024 05:22
Copy link

github-actions bot commented Sep 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10651315387.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 1, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, since most AI armed with the grenades are likely to be toxers immune to the gas (or a player who knows better).

@N7Huntsman N7Huntsman merged commit ce0ad0b into CombatExtended-Continued:Development Sep 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants