Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheat on Projectile and Weapon drawing positions to mask camera problems #3386

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

perkinslr
Copy link
Contributor

Changes

  • Weapons can have their vertical draw position tweaked while pawns are warming up or recoiling.
  • Projectiles fudge their draw position for the first few ticks (default 5) to hide the latent camera perspective issues

Alternatives

  • Fully lie about projectile positions
  • Draw projectile positions accurately, ignoring visual issues
  • Change virtual camera perspective

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners September 1, 2024 17:43
Copy link

github-actions bot commented Sep 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10656108770.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 1, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better in-game.

@N7Huntsman N7Huntsman merged commit e1e6043 into Development Sep 8, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the camera-fix branch September 8, 2024 20:07
@GrahammerTek GrahammerTek mentioned this pull request Sep 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants