Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor assorted housekeeping #3411

Conversation

SamaelGray
Copy link
Contributor

Changes

  • Swapped the sharp AP of blunderbuss and mini cannon ball grape ammo.
  • Decreased the material requirement in the Royalty warhammer's recipe.

Reasoning

  • Blunderbuss shot should have had 3mm and the other 3.5mm, not the other way around.
  • The CE Melee maul is heavier and requires 120 materials which is the baseline, the warhammer being lighter and costing 150 doesn't make sense.

Alternatives

  • Make the CE Melee maul require more work and materials? It requires 4000 less work in comparison too.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@SamaelGray SamaelGray requested review from a team as code owners September 10, 2024 15:20
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10795575796.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 10, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the projectiles sheet with the blunderbuss/mini cannon stuff.

Since the CE Melee maul pre-dates the Royalty Warhammer, I'd probably increase the material cost of the Maul, rather than reducing the warhammer. At 100, it costs the same amount of material to make as a longsword, which doesn't make a lot of sense to me.

Or perhaps adjust both? I'd probably set the Maul to 150 material, and the warhammer to 125.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10805824702.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10805837650.zip

@N7Huntsman N7Huntsman merged commit c40868e into CombatExtended-Continued:Development Sep 11, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-MinorFixes branch September 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants