Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CE Patch for Wall Armor #3413

Closed

Conversation

Diakon5
Copy link

@Diakon5 Diakon5 commented Sep 11, 2024

Additions

Describe new functionality added by your code, e.g.

  • Fixed a patch for ReBuild: Walls and Corners 's wall armor. CE was trying to patch the damageMultipliers of the Wall armor, a node that didn't exist for some reason.

Changes

Patch now checks if damageMultipliers node exists before patching

References

None

Reasoning

I was clearing errors from my log

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@Diakon5 Diakon5 requested review from a team as code owners September 11, 2024 10:13
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10809609280.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 11, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear on this PR; you're removing patches to two structures (RB_ReinforcedGlassWall and RB_ReinforcedClerestoryWall), and pointing the operations at something that doesn't have a damage multiplier in the original def?

We previously fixed an issue with this patch, and at the moment I'm not getting any errors on start when using the development branch.

@Diakon5
Copy link
Author

Diakon5 commented Sep 12, 2024

...Huh. Yes. And I pushed the very same fix once again, because the issue still exists in the release branch. I should've read the Git differences. My apologies

@Diakon5 Diakon5 closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants