Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Profaned #3423

Merged

Conversation

ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented Sep 16, 2024

Additions

Describe new functionality added by your code, e.g.

  • Patch base pawnKinds for ammo
  • Patches SpectralGreatbowArrow projectile to be similar to plasteel arrow
  • Adds new shield rendering to Profaned Shield

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Remove unneeded PawnKindDefs and associated patch after feedback
  • Change Spectral Greatbow to just use the Spectral Greatbow Arrow. Supposed to be a magical upgrade of the profaned greatbow.

Reasoning

Why did you choose to implement things this way, e.g.

  • Feedback on pawnKinds
  • Spectral Greatbow supposed to be magical upgraded on par with the others. Magic arrows are a fair trade off for the base game's VE homing projectiles.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

* Change Spectral Greatbow to just use the Spectral Greatbow Arrow. Supposed to be a magical upgrade of the profaned greatbow
* Patches SpectralGreatbowArrow projectile to be similar to plasteel arrow
* Patch pawnKinds for ammo
* Remove unneeded PawnKindDefs and associated patch
@ViralReaction ViralReaction requested review from a team as code owners September 16, 2024 18:57
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10890258810.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 16, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10891265540.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10893684741.zip

@N7Huntsman N7Huntsman merged commit 935727c into CombatExtended-Continued:Development Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants