Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20x82mm casing mass fix and misc typo fix #3429

Conversation

SamaelGray
Copy link
Contributor

Changes

  • What it says on the tin, increased the casing mass from 65 to 95 grams.

References

Reasoning

  • As noted in my spreadsheet, the total cartridge mass of 20x82mm is 205 grams, which with a 110 grams projectile it makes the rest of the cartridge have 95 grams off mass. 65 grams might have been a silly typo.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@SamaelGray SamaelGray requested review from a team as code owners September 17, 2024 18:51
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10909213319.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 17, 2024
@SamaelGray SamaelGray changed the title 20x82mm casing mass fix 20x82mm casing mass fix and misc typo fix Sep 18, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10916395684.zip

@N7Huntsman N7Huntsman merged commit 9c6a0bc into CombatExtended-Continued:Development Sep 18, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-20x82mmFixed branch September 18, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants