Update roslyn #3431
Merged
Update roslyn #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10928141611.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10928651183.zip |
N7Huntsman
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Downloads the updated roslyn compiler from CombatExtended-Continued/roslyn and uses it to compile CE
References
Links to the associated issues or other related pull requests, e.g.
Reasoning
The mono project is in flux, so the embedded version of the roslyn compiler is stuck on C# 9. The external roslyn compiler supports C# 13. This lets us use C# 13 syntax in CE when beneficial.
Alternatives
Disable automatic building of PRs and use dotnet to compile.
Stick with C# 9 only.
Reimplement the csc frontend (it's actually fairly small, similar to the publicizer stuff)
Testing
Check tests you have performed: