Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biotech gas mask tags fix #3432

Conversation

chief-turkler
Copy link
Contributor

@chief-turkler chief-turkler commented Sep 19, 2024

Changes

The Biotech patch now copies over the tags of the Combat Extended gas mask apparel to the Biotech gas mask apparel.

Reasoning

  • People asked me to:

image

  • Combat Extended has its own specific GasMask tag and the Biotech gas mask using the IndustrialBasic causes issues, like random pawns spawning with gas masks, that are not present in Combat Extended

Alternatives

  • Completely removing the item overlap:
    • Would be prefered, arguably leaving two different but identical items is a bit sloppy, but removals of those items were rejected in the past.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (15 minutes, crafted some gas masks and made sure they worked fine)

@chief-turkler chief-turkler requested review from a team as code owners September 19, 2024 14:48
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10943437418.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 19, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine. Only chief concern about not maintaining the vanilla tags was the prospect of removing the gas mask from a pawn that needed it and was assigned it via IndustrialBasic, but it looks like the various Toxers have IndustrialMilitaryBasic.

@N7Huntsman N7Huntsman merged commit 25cb11b into CombatExtended-Continued:Development Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants