Defer gear-tab armor calcs to CE_Utility #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10984399166.zip |
github-actions
bot
added
the
Download in Comments
perkinslr
force-pushed
the
fix-pa-inventory-display
branch
from
ca7acc0 to
5fe2aca
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10984419851.zip |
Thorbane
previously approved these changes
Sep 23, 2024
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10987967659.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10988146887.zip |
N7Huntsman
approved these changes
Sep 23, 2024
Thorbane
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of trying to duplicate the functionality in CE_Utility inline in the gear tab, we just use the same function to calculate location specific armor values.
Reasoning
Changes to location based armor calculations (like the natural armor, and later location-specific partial armor) lead to the two versions of the code getting out of sync. Always using the same calculation means the reported value should match the value the damage system actually uses.
Alternatives
Fix the de-sync one issue at a time, forever.
Testing
Check tests you have performed: