Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Generic-only patch ops #3454

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Add Generic-only patch ops #3454

merged 6 commits into from
Oct 31, 2024

Conversation

Safairette
Copy link
Contributor

@Safairette Safairette commented Sep 27, 2024 •
edited
Loading

Additions

  • Added a conditional patch op that triggers depending on whether standard or generic ammo mode is enabled.

Changes

  • Changed patches of VE Deserters and Ancients to use the new patch op.

Reasoning

  • Could be useful for adding generics to things that don't support ammosets, like the VFE Deserters intel shop and other stuff like it.

Alternatives

  • Improve the generalizer enough to catch references to the original ammo defs across ALL defs and automatically replace with generics.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded

@Safairette Safairette requested review from a team as code owners September 27, 2024 11:27
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11069788339.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 27, 2024
@N7Huntsman N7Huntsman marked this pull request as draft October 25, 2024 05:56
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11522765819.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11525468896.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11531494105.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11532661505.zip

@Safairette Safairette marked this pull request as ready for review October 26, 2024 14:44
N7Huntsman
N7Huntsman approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly testing the Ancients and Deserters use cases included. Good work.

MaxDorob
MaxDorob approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@MaxDorob MaxDorob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# code looks good

@N7Huntsman N7Huntsman merged commit 5566b2f into Development Oct 31, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the GenericOnlyPatchOps branch October 31, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDorob MaxDorob MaxDorob approved these changes

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Safairette @N7Huntsman @MaxDorob