Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update [K4G] Empires of Old #3498

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Update [K4G] Empires of Old #3498

merged 9 commits into from
Oct 31, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Oct 21, 2024 •
edited
Loading

Additions

  • Additional patches for new weapons and equipment added since the patch was written.

Changes

  • Fix a typo in the Alekeeper packageID.
  • Whitespace housekeeping.

Reasoning

  • New stuff, needs patching. Patched based upon stats of existing weapons.
    • Shortbarrel rifle patched as stockless G3.
    • Drum rifle patched as HK 21 (GPMG variant of the G3).

Alternatives

  • Suffer

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners October 21, 2024 08:01
@N7Huntsman N7Huntsman marked this pull request as draft October 21, 2024 08:01
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11435766980.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 21, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11529214302.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11536956874.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11565511499.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11565513469.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review October 31, 2024 08:55
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11608867365.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11608876705.zip

Airomeda
Airomeda approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@N7Huntsman N7Huntsman merged commit 18e1541 into Development Oct 31, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the K4G-Update branch October 31, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @Airomeda