Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial natural armor fixes #3499

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Oct 23, 2024

Changes

  • Added the necessary patches to make partial natural armor on insect legs and mech sensory parts properly and actually apply.
  • Modded pawns will also be added.

Reasoning

  • As it has recently turned out, after a decent amount of complaining about the issue, that partial natural armor only applies to bodyparts that originally have the CoveredByNaturalArmor tag and this was not apparent in the initial testing I did on the system for some reason that I can't remember since it was 2 years ago. So to fix insect legs and mech sensory parts not actually having partial armor since forever, I've added the required patches...

Alternatives

  • Suffer...

Testing

Check tests you have performed:

@SamaelGray SamaelGray requested review from a team as code owners October 23, 2024 11:04
@SamaelGray SamaelGray marked this pull request as draft October 23, 2024 11:06
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11478559784.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 23, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11526064604.zip

@SamaelGray SamaelGray marked this pull request as ready for review October 25, 2024 22:11
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11788448239.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11789081856.zip

@N7Huntsman N7Huntsman merged commit 621f7f5 into CombatExtended-Continued:Development Nov 12, 2024
3 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-PartialArmorFixed branch November 12, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants