Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Pyrinth Mod #3506

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Patch Pyrinth Mod #3506

merged 3 commits into from
Oct 26, 2024

Conversation

N7Huntsman
Copy link
Contributor

Additions

  • Patch for the Epoch - Pyrinth mod.
    • New longsword-like weapon.
    • Add appropriate bulk to the new material.

Reasoning

  • The new weapon is largely identical to the longsword, but in the mod has a slightly shorter cooldown. I've expanded this to the sword being slightly faster overall, giving it a bit higher blunt and sharp AP. Dodge is also a bit better, at the cost of parry and counter parry.

Alternatives

  • Different balance scheme, I guess.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (like 5 minutes)

@N7Huntsman N7Huntsman requested review from a team as code owners October 25, 2024 08:07
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11514362322.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 25, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11514374837.zip

Tostov
Tostov previously approved these changes Oct 25, 2024
Copy link
Contributor

@Tostov Tostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though it may be worth patching the weight down for the sword to work with CE's inventory because 10kg for a regular-ish sword is a bit excessive.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11524707398.zip

Copy link
Contributor

@Tostov Tostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@N7Huntsman N7Huntsman merged commit 5502b77 into Development Oct 26, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the Pyrinth-Patch branch October 26, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants