Fix retaliation raids and shelling #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #3419, retaliation raids currently cause infinite error spam if the bombardment that triggered the retaliation was from a temporary map that was disposed of by the time the raid was actually executed. Fix it by checking whether the target map for the raid is actually valid. While testing this, I found that retaliation shelling has also been broken since d90f3e1. Fix it by accounting for the case where the launcher is not spawned at all, since retaliation bombardment shells are "launched" by world pawns.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11541883961.zip |
github-actions
bot
added
the
Download in Comments
|
Here's a test save with everything setup and a retaliation raid + shells already incoming: temp_map_bomb.rws.zip |
N7Huntsman
previously approved these changes
Oct 28, 2024
As reported in #3419, retaliation raids currently cause infinite error spam if the bombardment that triggered the retaliation was from a temporary map that was disposed of by the time the raid was actually executed. Fix it by checking whether the target map for the raid is actually valid. While testing this, I found that retaliation shelling has also been broken since d90f3e1. Fix it by accounting for the case where the launcher is not spawned at all, since retaliation bombardment shells are "launched" by world pawns. Also ensure bombardments from other factions' settlements do not trigger a retaliation bombardment if the target faction isn't hostile to the owner of the tile, and introduce a configurable retaliation fire delay that scales with how damaged a site is.
mszabo-wikia
force-pushed
the
fix-retaliation
branch
from
2b14d2e to
0e271eb
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11604185016.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11626033919.zip |
N7Huntsman
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As reported in #3419, retaliation raids currently cause infinite error spam if the bombardment that triggered the retaliation was from a temporary map that was disposed of by the time the raid was actually executed. Fix it by checking whether the target map for the raid is actually valid.
While testing this, I found that retaliation shelling has also been broken since d90f3e1. Fix it by accounting for the case where the launcher is not spawned at all, since retaliation bombardment shells are "launched" by world pawns.
Also ensure bombardments from other factions' settlements do not trigger a retaliation
bombardment if the target faction isn't hostile to the owner of the tile,
and introduce a configurable retaliation fire delay that scales with how damaged a
site is.
References
Testing
Check tests you have performed: