Consistently apply shot height adjustment #3516
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f52a9f introduced a system to adjust the shot height dynamically to compensate for the case where the target is partially obscured by cover or is tall enough for its center of mass to be higher than the shot height. However, this is currently applied only inconsistently: while all projectiles take it into account for shot line checks, only instant (IE: laser) weapons actually apply it to the projectile being fired. Fix it by making the height and angle adjustments part of ShiftVecReport and using them as needed.
|
Marking this as draft for now since the behavior doesn't seem to be as expected—the sniper in the attached test save missed 10 out of 10 shots at the pawn behind the embrasure, while he fairly consistently hit him on the first or second try on the Development branch. However, he also hits consistently if I set the angle adjustment ( |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11544578843.zip |
github-actions
bot
added
the
Download in Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
0f52a9f introduced a system to adjust the shot height dynamically to compensate for the case where the target is partially obscured by cover or is tall enough for its center of mass to be higher than the shot height. However, this is currently applied only inconsistently: while all projectiles take it into account for shot line checks, only instant (IE: laser) weapons actually apply it to the projectile being fired.
Fix it by making the height and angle adjustments part of ShiftVecReport and using them as needed.
Testing
Check tests you have performed: